From 36bbeb336584c3551bac72592bcaeeebb430fef1 Mon Sep 17 00:00:00 2001 From: Colin Ian King Date: Mon, 6 Sep 2021 14:44:38 +0100 Subject: [PATCH] ksmbd: add missing assignments to ret on ndr_read_int64 read calls Currently there are two ndr_read_int64 calls where ret is being checked for failure but ret is not being assigned a return value from the call. Static analyis is reporting the checks on ret as dead code. Fix this. Addresses-Coverity: ("Logical dead code") Reviewed-by: Sergey Senozhatsky Signed-off-by: Colin Ian King Signed-off-by: Namjae Jeon Signed-off-by: Steve French --- fs/ksmbd/ndr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ksmbd/ndr.c b/fs/ksmbd/ndr.c index a476de291f62..8317f7ca402b 100644 --- a/fs/ksmbd/ndr.c +++ b/fs/ksmbd/ndr.c @@ -275,11 +275,11 @@ int ndr_decode_dos_attr(struct ndr *n, struct xattr_dos_attrib *da) if (ret) return ret; - ndr_read_int64(n, NULL); + ret = ndr_read_int64(n, NULL); if (ret) return ret; - ndr_read_int64(n, NULL); + ret = ndr_read_int64(n, NULL); if (ret) return ret;