mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-06 02:50:43 +00:00
NFSD: Fix use-after-free warning when doing inter-server copy
The source file nfsd_file is not constructed the same as other
nfsd_file's via nfsd_file_alloc. nfsd_file_put should not be
called to free the object; nfsd_file_put is not the inverse of
kzalloc, instead kfree is called by nfsd4_do_async_copy when done.
Fixes: ce0887ac96
("NFSD add nfs4 inter ssc to nfsd4_copy")
Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
This commit is contained in:
parent
66d60e3ad1
commit
36e1e5ba90
1 changed files with 1 additions and 1 deletions
|
@ -1299,7 +1299,7 @@ nfsd4_cleanup_inter_ssc(struct vfsmount *ss_mnt, struct nfsd_file *src,
|
|||
struct nfsd_file *dst)
|
||||
{
|
||||
nfs42_ssc_close(src->nf_file);
|
||||
nfsd_file_put(src);
|
||||
/* 'src' is freed by nfsd4_do_async_copy */
|
||||
nfsd_file_put(dst);
|
||||
mntput(ss_mnt);
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue