mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-18 08:35:03 +00:00
Code Issues Releases Wiki Activity

x86/kaslr: Drop test for command-line parameters before parsing

Browse source 
This check doesn't save anything. In the case when none of the
parameters are present, each strstr will scan args twice (once to find
the length and then for searching), six scans in total. Just going ahead
and parsing the arguments only requires three scans: strlen, memcpy, and
parsing. This will be the first malloc, so free will actually free up
the memory, so the check doesn't save heap space either.

Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20200728225722.67457-14-nivedita@alum.mit.edu
This commit is contained in:
Arvind Sankar 2020-07-28 18:57:14 -04:00 committed by Ingo Molnar
parent be9e8d9541
commit 3870d97179
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
arch/x86/boot/compressed/kaslr.c
View file

@ -279,10 +279,6 @@ static void handle_mem_options(void)
if (!args)
return;
if (!strstr(args, "memmap=") && !strstr(args, "mem=") &&
!strstr(args, "hugepages"))
return;
len = strlen(args);
tmp_cmdline = malloc(len + 1);
if (!tmp_cmdline)