mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-13 14:14:37 +00:00
NFS: nfs_igrab_and_active must first reference the superblock
commit896567ee7f
upstream. Before referencing the inode, we must ensure that the superblock can be referenced. Otherwise, we can end up with iput() calling superblock operations that are no longer valid or accessible. Fixes:ea7c38fef0
("NFSv4: Ensure we reference the inode for return-on-close in delegreturn") Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
6b3ae2030d
commit
38992092b5
1 changed files with 7 additions and 5 deletions
|
@ -569,12 +569,14 @@ extern void nfs4_test_session_trunk(struct rpc_clnt *clnt,
|
|||
|
||||
static inline struct inode *nfs_igrab_and_active(struct inode *inode)
|
||||
{
|
||||
inode = igrab(inode);
|
||||
if (inode != NULL && !nfs_sb_active(inode->i_sb)) {
|
||||
iput(inode);
|
||||
inode = NULL;
|
||||
struct super_block *sb = inode->i_sb;
|
||||
|
||||
if (sb && nfs_sb_active(sb)) {
|
||||
if (igrab(inode))
|
||||
return inode;
|
||||
nfs_sb_deactive(sb);
|
||||
}
|
||||
return inode;
|
||||
return NULL;
|
||||
}
|
||||
|
||||
static inline void nfs_iput_and_deactive(struct inode *inode)
|
||||
|
|
Loading…
Reference in a new issue