tty: vt: remove checks for count in consw::con_clear() implementations
'count' in consw::con_clear() is guaranteed to be positive. csi_X() (the only caller) takes the minimum of the vc parameter (which is at least 1) and count of characters till the end of the line. The latter is computed as a subtraction of vc->vc_cols (count) and vc->state.x (offset). So for the worst case, full line, it is 1. Therefore, there is no point in checking zero or negative values (width is now unsigned anyway). Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org> Cc: Helge Deller <deller@gmx.de> Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com> Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-parisc@vger.kernel.org Tested-by: Helge Deller <deller@gmx.de> # parisc STI console Link: https://lore.kernel.org/r/20240122110401.7289-23-jirislaby@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
559f01a0ee
commit
3ab8a65193
|
@ -448,9 +448,6 @@ static void mdacon_clear(struct vc_data *c, unsigned int y, unsigned int x,
|
|||
u16 *dest = mda_addr(x, y);
|
||||
u16 eattr = mda_convert_attr(c->vc_video_erase_char);
|
||||
|
||||
if (width <= 0)
|
||||
return;
|
||||
|
||||
scr_memsetw(dest, eattr, width * 2);
|
||||
}
|
||||
|
||||
|
|
|
@ -303,9 +303,6 @@ static void sticon_deinit(struct vc_data *c)
|
|||
static void sticon_clear(struct vc_data *conp, unsigned int sy, unsigned int sx,
|
||||
unsigned int width)
|
||||
{
|
||||
if (!width)
|
||||
return;
|
||||
|
||||
sti_clear(sticon_sti, sy, sx, 1, width,
|
||||
conp->vc_video_erase_char, font_data[conp->vc_num]);
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue