mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 09:19:51 +00:00
staging: erofs: fix memleak of inode's shared xattr array
If it fails to read a shared xattr page, the inode's shared xattr array
is not freed. The next time the inode's xattr is accessed, the previously
allocated array is leaked.
Signed-off-by: Sheng Yong <shengyong1@huawei.com>
Fixes: b17500a0fd
("staging: erofs: introduce xattr & acl support")
Cc: <stable@vger.kernel.org> # 4.19+
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
e7dd3d47bc
commit
3b1b5291f7
1 changed files with 4 additions and 1 deletions
|
@ -111,8 +111,11 @@ static int init_inode_xattrs(struct inode *inode)
|
||||||
|
|
||||||
it.page = erofs_get_meta_page(sb,
|
it.page = erofs_get_meta_page(sb,
|
||||||
++it.blkaddr, S_ISDIR(inode->i_mode));
|
++it.blkaddr, S_ISDIR(inode->i_mode));
|
||||||
if (IS_ERR(it.page))
|
if (IS_ERR(it.page)) {
|
||||||
|
kfree(vi->xattr_shared_xattrs);
|
||||||
|
vi->xattr_shared_xattrs = NULL;
|
||||||
return PTR_ERR(it.page);
|
return PTR_ERR(it.page);
|
||||||
|
}
|
||||||
|
|
||||||
it.kaddr = kmap_atomic(it.page);
|
it.kaddr = kmap_atomic(it.page);
|
||||||
atomic_map = true;
|
atomic_map = true;
|
||||||
|
|
Loading…
Reference in a new issue