mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 22:02:02 +00:00
spi: xilinx: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230303172041.2103336-85-u.kleine-koenig@pengutronix.de Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
parent
1b13d196d2
commit
3b1d7e1193
1 changed files with 2 additions and 4 deletions
|
@ -504,7 +504,7 @@ static int xilinx_spi_probe(struct platform_device *pdev)
|
|||
return 0;
|
||||
}
|
||||
|
||||
static int xilinx_spi_remove(struct platform_device *pdev)
|
||||
static void xilinx_spi_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct spi_master *master = platform_get_drvdata(pdev);
|
||||
struct xilinx_spi *xspi = spi_master_get_devdata(master);
|
||||
|
@ -518,8 +518,6 @@ static int xilinx_spi_remove(struct platform_device *pdev)
|
|||
xspi->write_fn(0, regs_base + XIPIF_V123B_DGIER_OFFSET);
|
||||
|
||||
spi_master_put(xspi->bitbang.master);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
/* work with hotplug and coldplug */
|
||||
|
@ -527,7 +525,7 @@ MODULE_ALIAS("platform:" XILINX_SPI_NAME);
|
|||
|
||||
static struct platform_driver xilinx_spi_driver = {
|
||||
.probe = xilinx_spi_probe,
|
||||
.remove = xilinx_spi_remove,
|
||||
.remove_new = xilinx_spi_remove,
|
||||
.driver = {
|
||||
.name = XILINX_SPI_NAME,
|
||||
.of_match_table = xilinx_spi_of_match,
|
||||
|
|
Loading…
Reference in a new issue