mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-27 19:29:37 +00:00
[PATCH] PCI Hotplug: PCI panic on dlpar add (add pci slot to running partition)
Removing and then adding a PCI slot to a running partition results in a kernel panic. The current code attempts to add iospace for an entire root bus, which is inappropriate, and silently fails. When a pci device tries to use the iospace, a page fault is taken, as the iospace had not been mapped, and of course the page fault cannot be resolved. This only occurs for PCI adapters using pio, which may be why it hadn't been seen earlier (this seems to have been broken for a while). This patch has survived testing of dozens of slot add and removes. Signed-off-by: Linas Vepstas <linas@austin.ibm.com> Acked-by: John Rose <johnrose@austin.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
dd8c499668
commit
3c0c644188
1 changed files with 1 additions and 1 deletions
|
@ -152,7 +152,7 @@ static struct pci_dev *dlpar_pci_add_bus(struct device_node *dn)
|
||||||
pcibios_claim_one_bus(dev->bus);
|
pcibios_claim_one_bus(dev->bus);
|
||||||
|
|
||||||
/* ioremap() for child bus, which may or may not succeed */
|
/* ioremap() for child bus, which may or may not succeed */
|
||||||
(void) remap_bus_range(dev->bus);
|
remap_bus_range(dev->subordinate);
|
||||||
|
|
||||||
/* Add new devices to global lists. Register in proc, sysfs. */
|
/* Add new devices to global lists. Register in proc, sysfs. */
|
||||||
pci_bus_add_devices(phb->bus);
|
pci_bus_add_devices(phb->bus);
|
||||||
|
|
Loading…
Reference in a new issue