mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-01 14:44:12 +00:00
Code Issues Releases Wiki Activity

staging/ks7010: Remove all strcpy() uses in favor of strscpy()

Browse source 
strcpy() performs no bounds checking on the destination buffer. This
could result in linear overflows beyond the end of the buffer, leading
to all kinds of misbehaviors. The safe replacement is strscpy().

Signed-off-by: Len Baker <len.baker@gmx.com>
Link: https://lore.kernel.org/r/20210723145122.5746-1-len.baker@gmx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Len Baker 2021-07-23 16:51:22 +02:00 committed by Greg Kroah-Hartman
parent cf79ee6eb0
commit 3c6675363d
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
drivers/staging/ks7010/ks_wlan_net.c
View file

@ -158,13 +158,13 @@ static int ks_wlan_get_name(struct net_device *dev,
/* for SLEEP MODE */
if (priv->dev_state < DEVICE_STATE_READY)
strcpy(cwrq->name, "NOT READY!");
strscpy(cwrq->name, "NOT READY!", sizeof(cwrq->name));
else if (priv->reg.phy_type == D_11B_ONLY_MODE)
strcpy(cwrq->name, "IEEE 802.11b");
strscpy(cwrq->name, "IEEE 802.11b", sizeof(cwrq->name));
else if (priv->reg.phy_type == D_11G_ONLY_MODE)
strcpy(cwrq->name, "IEEE 802.11g");
strscpy(cwrq->name, "IEEE 802.11g", sizeof(cwrq->name));
else
strcpy(cwrq->name, "IEEE 802.11b/g");
strscpy(cwrq->name, "IEEE 802.11b/g", sizeof(cwrq->name));
return 0;
}
@ -1808,8 +1808,8 @@ static int ks_wlan_get_firmware_version(struct net_device *dev,
{
struct ks_wlan_private *priv = netdev_priv(dev);
strcpy(extra, priv->firmware_version);
dwrq->length = priv->version_size + 1;
strscpy(extra, priv->firmware_version, dwrq->length);
return 0;
}