sctp: remove rcu_read_lock from sctp_bind_addr_state
sctp_bind_addr_state() is called either in packet rcv path or by sctp_copy_local_addr_list(), which are under rcu_read_lock. So there's no need to call it again in sctp_bind_addr_state(). Signed-off-by: Xin Long <lucien.xin@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
6c6fbad657
commit
3cab2afb14
|
@ -393,24 +393,19 @@ int sctp_bind_addr_state(const struct sctp_bind_addr *bp,
|
||||||
{
|
{
|
||||||
struct sctp_sockaddr_entry *laddr;
|
struct sctp_sockaddr_entry *laddr;
|
||||||
struct sctp_af *af;
|
struct sctp_af *af;
|
||||||
int state = -1;
|
|
||||||
|
|
||||||
af = sctp_get_af_specific(addr->sa.sa_family);
|
af = sctp_get_af_specific(addr->sa.sa_family);
|
||||||
if (unlikely(!af))
|
if (unlikely(!af))
|
||||||
return state;
|
return -1;
|
||||||
|
|
||||||
rcu_read_lock();
|
|
||||||
list_for_each_entry_rcu(laddr, &bp->address_list, list) {
|
list_for_each_entry_rcu(laddr, &bp->address_list, list) {
|
||||||
if (!laddr->valid)
|
if (!laddr->valid)
|
||||||
continue;
|
continue;
|
||||||
if (af->cmp_addr(&laddr->a, addr)) {
|
if (af->cmp_addr(&laddr->a, addr))
|
||||||
state = laddr->state;
|
return laddr->state;
|
||||||
break;
|
|
||||||
}
|
}
|
||||||
}
|
|
||||||
rcu_read_unlock();
|
|
||||||
|
|
||||||
return state;
|
return -1;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Find the first address in the bind address list that is not present in
|
/* Find the first address in the bind address list that is not present in
|
||||||
|
|
Loading…
Reference in New Issue