mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-14 04:26:45 +00:00
Code Issues Releases Wiki Activity

[PATCH] fix create_write_pipe() error check

Browse source 
The return value of create_write_pipe()/create_read_pipe() should be
checked by IS_ERR().

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Akinobu Mita 2006-11-28 12:29:43 -08:00 committed by Linus Torvalds
parent 967bf623e9
commit 3cce4856ff
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
kernel/kmod.c
View file

@ -307,14 +307,14 @@ int call_usermodehelper_pipe(char *path, char **argv, char **envp,
return 0; return 0;
f = create_write_pipe(); f = create_write_pipe();
if (!f) if (IS_ERR(f))
return -ENOMEM; return PTR_ERR(f);
*filp = f; *filp = f;
f = create_read_pipe(f); f = create_read_pipe(f);
if (!f) { if (IS_ERR(f)) {
free_write_pipe(*filp); free_write_pipe(*filp);
return -ENOMEM; return PTR_ERR(f);
} }
sub_info.stdin = f; sub_info.stdin = f;