mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 09:19:51 +00:00
perf tools: No need to cache the PMUs in ARM SPE auxtrace init routine
- auxtrace_record__init() is called only once, so there is no point in using a static variable to cache the results of find_all_arm_spe_pmus(), make it local and free the results after use. - Another reason is, even though SPE is micro-architecture dependent, but so far it only supports "statistical-profiling-extension-v1" and we have no chance to use multiple SPE's PMU events in Perf command. So remove the useless check code to make it clear. Signed-off-by: Wei Li <liwei391@huawei.com> Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Hanjun Guo <guohanjun@huawei.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Kim Phillips <kim.phillips@arm.com> Cc: Leo Yan <leo.yan@linaro.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Mike Leach <mike.leach@linaro.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Suzuki Poulouse <suzuki.poulose@arm.com> Cc: linux-arm-kernel@lists.infradead.org Link: http://lore.kernel.org/lkml/20200724071111.35593-3-liwei391@huawei.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
parent
31e81e0bed
commit
3e43d79da1
1 changed files with 4 additions and 5 deletions
|
@ -57,16 +57,14 @@ struct auxtrace_record
|
||||||
struct evsel *evsel;
|
struct evsel *evsel;
|
||||||
bool found_etm = false;
|
bool found_etm = false;
|
||||||
struct perf_pmu *found_spe = NULL;
|
struct perf_pmu *found_spe = NULL;
|
||||||
static struct perf_pmu **arm_spe_pmus = NULL;
|
struct perf_pmu **arm_spe_pmus = NULL;
|
||||||
static int nr_spes = 0;
|
int nr_spes = 0;
|
||||||
int i = 0;
|
int i = 0;
|
||||||
|
|
||||||
if (!evlist)
|
if (!evlist)
|
||||||
return NULL;
|
return NULL;
|
||||||
|
|
||||||
cs_etm_pmu = perf_pmu__find(CORESIGHT_ETM_PMU_NAME);
|
cs_etm_pmu = perf_pmu__find(CORESIGHT_ETM_PMU_NAME);
|
||||||
|
|
||||||
if (!arm_spe_pmus)
|
|
||||||
arm_spe_pmus = find_all_arm_spe_pmus(&nr_spes, err);
|
arm_spe_pmus = find_all_arm_spe_pmus(&nr_spes, err);
|
||||||
|
|
||||||
evlist__for_each_entry(evlist, evsel) {
|
evlist__for_each_entry(evlist, evsel) {
|
||||||
|
@ -84,6 +82,7 @@ struct auxtrace_record
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
free(arm_spe_pmus);
|
||||||
|
|
||||||
if (found_etm && found_spe) {
|
if (found_etm && found_spe) {
|
||||||
pr_err("Concurrent ARM Coresight ETM and SPE operation not currently supported\n");
|
pr_err("Concurrent ARM Coresight ETM and SPE operation not currently supported\n");
|
||||||
|
|
Loading…
Reference in a new issue