mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-27 12:57:53 +00:00
Bluetooth: add quirk for broken address properties
commit39646f29b1
upstream. Some Bluetooth controllers lack persistent storage for the device address and instead one can be provided by the boot firmware using the 'local-bd-address' devicetree property. The Bluetooth devicetree bindings clearly states that the address should be specified in little-endian order, but due to a long-standing bug in the Qualcomm driver which reversed the address some boot firmware has been providing the address in big-endian order instead. Add a new quirk that can be set on platforms with broken firmware and use it to reverse the address when parsing the property so that the underlying driver bug can be fixed. Fixes:5c0a1001c8
("Bluetooth: hci_qca: Add helper to set device address") Cc: stable@vger.kernel.org # 5.1 Reviewed-by: Douglas Anderson <dianders@chromium.org> Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
a2812ff7ea
commit
3e773d04ae
2 changed files with 13 additions and 1 deletions
|
@ -175,6 +175,15 @@ enum {
|
|||
*/
|
||||
HCI_QUIRK_USE_BDADDR_PROPERTY,
|
||||
|
||||
/* When this quirk is set, the Bluetooth Device Address provided by
|
||||
* the 'local-bd-address' fwnode property is incorrectly specified in
|
||||
* big-endian order.
|
||||
*
|
||||
* This quirk can be set before hci_register_dev is called or
|
||||
* during the hdev->setup vendor callback.
|
||||
*/
|
||||
HCI_QUIRK_BDADDR_PROPERTY_BROKEN,
|
||||
|
||||
/* When this quirk is set, the duplicate filtering during
|
||||
* scanning is based on Bluetooth devices addresses. To allow
|
||||
* RSSI based updates, restart scanning if needed.
|
||||
|
|
|
@ -3293,7 +3293,10 @@ static void hci_dev_get_bd_addr_from_property(struct hci_dev *hdev)
|
|||
if (ret < 0 || !bacmp(&ba, BDADDR_ANY))
|
||||
return;
|
||||
|
||||
bacpy(&hdev->public_addr, &ba);
|
||||
if (test_bit(HCI_QUIRK_BDADDR_PROPERTY_BROKEN, &hdev->quirks))
|
||||
baswap(&hdev->public_addr, &ba);
|
||||
else
|
||||
bacpy(&hdev->public_addr, &ba);
|
||||
}
|
||||
|
||||
struct hci_init_stage {
|
||||
|
|
Loading…
Reference in a new issue