mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-28 15:20:41 +00:00
Code Issues Releases Wiki Activity

staging: most: usb: remove overcautious parameter checking

Browse source 
The interface pointer passed to a core API function cannot be NULL. This
patch removes unnessecary the sanity check of the pointer.

Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/1588672829-28883-2-git-send-email-christian.gromm@microchip.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Christian Gromm 2020-05-05 12:00:26 +02:00 committed by Greg Kroah-Hartman
parent d97a9d7aea
commit 3e8621aba7
1 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/staging/most/usb/usb.c
View file

@ -233,10 +233,6 @@ static int hdm_poison_channel(struct most_interface *iface, int channel)
unsigned long flags; unsigned long flags;
spinlock_t *lock; /* temp. lock */ spinlock_t *lock; /* temp. lock */
if (unlikely(!iface)) {
dev_warn(&mdev->usb_device->dev, "Poison: Bad interface.\n");
return -EIO;
}
if (unlikely(channel < 0 || channel >= iface->num_channels)) { if (unlikely(channel < 0 || channel >= iface->num_channels)) {
dev_warn(&mdev->usb_device->dev, "Channel ID out of range.\n"); dev_warn(&mdev->usb_device->dev, "Channel ID out of range.\n");
return -ECHRNG; return -ECHRNG;
@ -559,7 +555,7 @@ static int hdm_enqueue(struct most_interface *iface, int channel,
unsigned long length; unsigned long length;
void *virt_address; void *virt_address;
if (unlikely(!iface || !mbo)) if (unlikely(!mbo))
return -EIO; return -EIO;
if (unlikely(iface->num_channels <= channel || channel < 0)) if (unlikely(iface->num_channels <= channel || channel < 0))
return -ECHRNG; return -ECHRNG;
@ -674,8 +670,8 @@ static int hdm_configure_channel(struct most_interface *iface, int channel,
mdev->clear_work[channel].mdev = mdev; mdev->clear_work[channel].mdev = mdev;
INIT_WORK(&mdev->clear_work[channel].ws, wq_clear_halt); INIT_WORK(&mdev->clear_work[channel].ws, wq_clear_halt);
if (unlikely(!iface || !conf)) { if (unlikely(!conf)) {
dev_err(dev, "Bad interface or config pointer.\n"); dev_err(dev, "Bad config pointer.\n");
return -EINVAL; return -EINVAL;
} }
if (unlikely(channel < 0 || channel >= iface->num_channels)) { if (unlikely(channel < 0 || channel >= iface->num_channels)) {
@ -747,7 +743,6 @@ static void hdm_request_netinfo(struct most_interface *iface, int channel,
{ {
struct most_dev *mdev; struct most_dev *mdev;
BUG_ON(!iface);
mdev = to_mdev(iface); mdev = to_mdev(iface);
mdev->on_netinfo = on_netinfo; mdev->on_netinfo = on_netinfo;
if (!on_netinfo) if (!on_netinfo)