mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-12 11:36:35 +00:00
drm/bridge: simple-bridg: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://patchwork.freedesktop.org/patch/msgid/20230318190804.234610-14-u.kleine-koenig@pengutronix.de
This commit is contained in:
parent
6780b94d8e
commit
3fce4c948e
1 changed files with 2 additions and 4 deletions
|
@ -218,13 +218,11 @@ static int simple_bridge_probe(struct platform_device *pdev)
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
static int simple_bridge_remove(struct platform_device *pdev)
|
static void simple_bridge_remove(struct platform_device *pdev)
|
||||||
{
|
{
|
||||||
struct simple_bridge *sbridge = platform_get_drvdata(pdev);
|
struct simple_bridge *sbridge = platform_get_drvdata(pdev);
|
||||||
|
|
||||||
drm_bridge_remove(&sbridge->bridge);
|
drm_bridge_remove(&sbridge->bridge);
|
||||||
|
|
||||||
return 0;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
/*
|
||||||
|
@ -301,7 +299,7 @@ MODULE_DEVICE_TABLE(of, simple_bridge_match);
|
||||||
|
|
||||||
static struct platform_driver simple_bridge_driver = {
|
static struct platform_driver simple_bridge_driver = {
|
||||||
.probe = simple_bridge_probe,
|
.probe = simple_bridge_probe,
|
||||||
.remove = simple_bridge_remove,
|
.remove_new = simple_bridge_remove,
|
||||||
.driver = {
|
.driver = {
|
||||||
.name = "simple-bridge",
|
.name = "simple-bridge",
|
||||||
.of_match_table = simple_bridge_match,
|
.of_match_table = simple_bridge_match,
|
||||||
|
|
Loading…
Reference in a new issue