mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-02 23:27:06 +00:00
Code Issues Releases Wiki Activity

gpio: idt3243x: Fix IRQ check in idt_gpio_probe

Browse source 
commit 30fee1d746 upstream.

platform_get_irq() returns negative error number instead 0 on failure.
And the doc of platform_get_irq() provides a usage example:

    int irq = platform_get_irq(pdev, 0);
    if (irq < 0)
        return irq;

Fix the check of return value to catch errors correctly.

Fixes: 4195926aed ("gpio: Add support for IDT 79RC3243x GPIO controller")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Miaoqian Lin 2022-01-14 06:51:24 +00:00 committed by Greg Kroah-Hartman
parent 4928241698
commit 405d639ac4
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/gpio/gpio-idt3243x.c
View file

@ -164,8 +164,8 @@ static int idt_gpio_probe(struct platform_device *pdev)
return PTR_ERR(ctrl->pic); return PTR_ERR(ctrl->pic);
parent_irq = platform_get_irq(pdev, 0); parent_irq = platform_get_irq(pdev, 0);
if (!parent_irq) if (parent_irq < 0)
return -EINVAL; return parent_irq;
girq = &ctrl->gc.irq; girq = &ctrl->gc.irq;
girq->chip = &idt_gpio_irqchip; girq->chip = &idt_gpio_irqchip;