mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-03 17:40:04 +00:00
Code Issues Releases Wiki Activity

media: cleanup fall-through comments

Browse source 
As Ian pointed out, adding a '-' to the fallthrough seems to meet
the regex requirements at level 3 of the warning, at least when
the comment fits into a single line.

So, replace by a single line the comments that were broken into
multiple lines just to make gcc -Wimplicit-fallthrough=3 happy.

Suggested-by: Ian Arkver <ian.arkver.dev@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Mauro Carvalho Chehab 2018-08-07 07:59:20 -04:00
parent 3354b54f9f
commit 40e431112c
4 changed files with 10 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/media/dvb-frontends/drx39xyj/drxj.c
View file

@ -2841,8 +2841,7 @@ ctrl_set_cfg_mpeg_output(struct drx_demod_instance *demod, struct drx_cfg_mpeg_o
/* coef = 188/204 */ /* coef = 188/204 */
max_bit_rate = max_bit_rate =
(ext_attr->curr_symbol_rate / 8) * nr_bits * 188; (ext_attr->curr_symbol_rate / 8) * nr_bits * 188;
/* pass through as b/c Annex A/c need following settings */ /* fall-through - as b/c Annex A/C need following settings */
/* fall-through */
case DRX_STANDARD_ITU_B: case DRX_STANDARD_ITU_B:
rc = drxj_dap_write_reg16(dev_addr, FEC_OC_FCT_USAGE__A, FEC_OC_FCT_USAGE__PRE, 0); rc = drxj_dap_write_reg16(dev_addr, FEC_OC_FCT_USAGE__A, FEC_OC_FCT_USAGE__PRE, 0);
if (rc != 0) { if (rc != 0) {

6
drivers/media/dvb-frontends/drxd_hard.c
View file

@ -1970,8 +1970,7 @@ static int DRX_Start(struct drxd_state *state, s32 off)
switch (p->transmission_mode) { switch (p->transmission_mode) {
default: /* Not set, detect it automatically */ default: /* Not set, detect it automatically */
operationMode |= SC_RA_RAM_OP_AUTO_MODE__M; operationMode |= SC_RA_RAM_OP_AUTO_MODE__M;
/* try first guess DRX_FFTMODE_8K */ /* fall through - try first guess DRX_FFTMODE_8K */
/* fall through */
case TRANSMISSION_MODE_8K: case TRANSMISSION_MODE_8K:
transmissionParams |= SC_RA_RAM_OP_PARAM_MODE_8K; transmissionParams |= SC_RA_RAM_OP_PARAM_MODE_8K;
if (state->type_A) { if (state->type_A) {
@ -2144,8 +2143,7 @@ static int DRX_Start(struct drxd_state *state, s32 off)
switch (p->modulation) { switch (p->modulation) {
default: default:
operationMode |= SC_RA_RAM_OP_AUTO_CONST__M; operationMode |= SC_RA_RAM_OP_AUTO_CONST__M;
/* try first guess DRX_CONSTELLATION_QAM64 */ /* fall through - try first guess DRX_CONSTELLATION_QAM64 */
/* fall through */
case QAM_64: case QAM_64:
transmissionParams |= SC_RA_RAM_OP_PARAM_CONST_QAM64; transmissionParams |= SC_RA_RAM_OP_PARAM_CONST_QAM64;
if (state->type_A) { if (state->type_A) {

18
drivers/media/dvb-frontends/drxk_hard.c
View file

@ -3270,13 +3270,11 @@ static int dvbt_sc_command(struct drxk_state *state,
case OFDM_SC_RA_RAM_CMD_SET_PREF_PARAM: case OFDM_SC_RA_RAM_CMD_SET_PREF_PARAM:
case OFDM_SC_RA_RAM_CMD_PROGRAM_PARAM: case OFDM_SC_RA_RAM_CMD_PROGRAM_PARAM:
status |= write16(state, OFDM_SC_RA_RAM_PARAM1__A, param1); status |= write16(state, OFDM_SC_RA_RAM_PARAM1__A, param1);
/* All commands using 1 parameters */ /* fall through - All commands using 1 parameters */
/* fall through */
case OFDM_SC_RA_RAM_CMD_SET_ECHO_TIMING: case OFDM_SC_RA_RAM_CMD_SET_ECHO_TIMING:
case OFDM_SC_RA_RAM_CMD_USER_IO: case OFDM_SC_RA_RAM_CMD_USER_IO:
status |= write16(state, OFDM_SC_RA_RAM_PARAM0__A, param0); status |= write16(state, OFDM_SC_RA_RAM_PARAM0__A, param0);
/* All commands using 0 parameters */ /* fall through - All commands using 0 parameters */
/* fall through */
case OFDM_SC_RA_RAM_CMD_GET_OP_PARAM: case OFDM_SC_RA_RAM_CMD_GET_OP_PARAM:
case OFDM_SC_RA_RAM_CMD_NULL: case OFDM_SC_RA_RAM_CMD_NULL:
/* Write command */ /* Write command */
@ -3784,8 +3782,7 @@ static int set_dvbt(struct drxk_state *state, u16 intermediate_freqk_hz,
case TRANSMISSION_MODE_AUTO: case TRANSMISSION_MODE_AUTO:
default: default:
operation_mode |= OFDM_SC_RA_RAM_OP_AUTO_MODE__M; operation_mode |= OFDM_SC_RA_RAM_OP_AUTO_MODE__M;
/* try first guess DRX_FFTMODE_8K */ /* fall through - try first guess DRX_FFTMODE_8K */
/* fall through */
case TRANSMISSION_MODE_8K: case TRANSMISSION_MODE_8K:
transmission_params |= OFDM_SC_RA_RAM_OP_PARAM_MODE_8K; transmission_params |= OFDM_SC_RA_RAM_OP_PARAM_MODE_8K;
break; break;
@ -3799,8 +3796,7 @@ static int set_dvbt(struct drxk_state *state, u16 intermediate_freqk_hz,
default: default:
case GUARD_INTERVAL_AUTO: case GUARD_INTERVAL_AUTO:
operation_mode |= OFDM_SC_RA_RAM_OP_AUTO_GUARD__M; operation_mode |= OFDM_SC_RA_RAM_OP_AUTO_GUARD__M;
/* try first guess DRX_GUARD_1DIV4 */ /* fall through - try first guess DRX_GUARD_1DIV4 */
/* fall through */
case GUARD_INTERVAL_1_4: case GUARD_INTERVAL_1_4:
transmission_params |= OFDM_SC_RA_RAM_OP_PARAM_GUARD_4; transmission_params |= OFDM_SC_RA_RAM_OP_PARAM_GUARD_4;
break; break;
@ -3841,8 +3837,7 @@ static int set_dvbt(struct drxk_state *state, u16 intermediate_freqk_hz,
case QAM_AUTO: case QAM_AUTO:
default: default:
operation_mode |= OFDM_SC_RA_RAM_OP_AUTO_CONST__M; operation_mode |= OFDM_SC_RA_RAM_OP_AUTO_CONST__M;
/* try first guess DRX_CONSTELLATION_QAM64 */ /* fall through - try first guess DRX_CONSTELLATION_QAM64 */
/* fall through */
case QAM_64: case QAM_64:
transmission_params |= OFDM_SC_RA_RAM_OP_PARAM_CONST_QAM64; transmission_params |= OFDM_SC_RA_RAM_OP_PARAM_CONST_QAM64;
break; break;
@ -3885,8 +3880,7 @@ static int set_dvbt(struct drxk_state *state, u16 intermediate_freqk_hz,
case FEC_AUTO: case FEC_AUTO:
default: default:
operation_mode |= OFDM_SC_RA_RAM_OP_AUTO_RATE__M; operation_mode |= OFDM_SC_RA_RAM_OP_AUTO_RATE__M;
/* try first guess DRX_CODERATE_2DIV3 */ /* fall through - try first guess DRX_CODERATE_2DIV3 */
/* fall through */
case FEC_2_3: case FEC_2_3:
transmission_params |= OFDM_SC_RA_RAM_OP_PARAM_RATE_2_3; transmission_params |= OFDM_SC_RA_RAM_OP_PARAM_RATE_2_3;
break; break;

3
drivers/staging/media/imx/imx-media-csi.c
View file

@ -460,8 +460,7 @@ static int csi_idmac_setup_channel(struct csi_priv *priv)
passthrough_cycles = incc->cycles; passthrough_cycles = incc->cycles;
break; break;
} }
/* for non-passthrough RGB565 (CSI-2 bus) */ /* fallthrough - non-passthrough RGB565 (CSI-2 bus) */
/* Falls through */
default: default:
burst_size = (image.pix.width & 0xf) ? 8 : 16; burst_size = (image.pix.width & 0xf) ? 8 : 16;
passthrough_bits = 16; passthrough_bits = 16;