iomap: Fix iomap_dio_rw return value for user copies
When a user copy fails in one of the helpers of iomap_dio_rw, fail with -EFAULT instead of returning 0. This matches what iomap_dio_bio_actor returns when it gets an -EFAULT from bio_iov_iter_get_pages. With these changes, iomap_dio_actor now consistently fails with -EFAULT when a user page cannot be faulted in. Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com> Reviewed-by: Darrick J. Wong <djwong@kernel.org> Reviewed-by: Christoph Hellwig <hch@lst.de>
This commit is contained in:
parent
00bfe02f47
commit
42c498c18a
|
@ -371,6 +371,8 @@ static loff_t iomap_dio_hole_iter(const struct iomap_iter *iter,
|
||||||
loff_t length = iov_iter_zero(iomap_length(iter), dio->submit.iter);
|
loff_t length = iov_iter_zero(iomap_length(iter), dio->submit.iter);
|
||||||
|
|
||||||
dio->size += length;
|
dio->size += length;
|
||||||
|
if (!length)
|
||||||
|
return -EFAULT;
|
||||||
return length;
|
return length;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -402,6 +404,8 @@ static loff_t iomap_dio_inline_iter(const struct iomap_iter *iomi,
|
||||||
copied = copy_to_iter(inline_data, length, iter);
|
copied = copy_to_iter(inline_data, length, iter);
|
||||||
}
|
}
|
||||||
dio->size += copied;
|
dio->size += copied;
|
||||||
|
if (!copied)
|
||||||
|
return -EFAULT;
|
||||||
return copied;
|
return copied;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue