mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-04 09:59:32 +00:00
gigaset: fix possible oops in error handling
Use pr_warning() / pr_err() instead of dev_warn() / dev_err() in two places where the dev pointer isn't guaranteed to be valid. Impact: error handling bugfix Signed-off-by: Tilman Schmidt <tilman@imap.cc> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
528efc6a54
commit
42e3d61115
2 changed files with 2 additions and 3 deletions
|
@ -599,8 +599,7 @@ void gigaset_if_init(struct cardstate *cs)
|
|||
if (!IS_ERR(cs->tty_dev))
|
||||
dev_set_drvdata(cs->tty_dev, cs);
|
||||
else {
|
||||
dev_warn(cs->dev,
|
||||
"could not register device to the tty subsystem\n");
|
||||
pr_warning("could not register device to the tty subsystem\n");
|
||||
cs->tty_dev = NULL;
|
||||
}
|
||||
mutex_unlock(&cs->mutex);
|
||||
|
|
|
@ -79,5 +79,5 @@ void gigaset_init_dev_sysfs(struct cardstate *cs)
|
|||
|
||||
gig_dbg(DEBUG_INIT, "setting up sysfs");
|
||||
if (device_create_file(cs->tty_dev, &dev_attr_cidmode))
|
||||
dev_err(cs->dev, "could not create sysfs attribute\n");
|
||||
pr_err("could not create sysfs attribute\n");
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue