mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-05 08:26:59 +00:00
usb: gadget/fsl_qe_udc: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Eventually after all drivers are converted, .remove_new() is renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230517230239.187727-31-u.kleine-koenig@pengutronix.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
2dd3f64fcc
commit
43efe68158
1 changed files with 2 additions and 4 deletions
|
@ -2628,7 +2628,7 @@ static int qe_udc_resume(struct platform_device *dev)
|
|||
}
|
||||
#endif
|
||||
|
||||
static int qe_udc_remove(struct platform_device *ofdev)
|
||||
static void qe_udc_remove(struct platform_device *ofdev)
|
||||
{
|
||||
struct qe_udc *udc = platform_get_drvdata(ofdev);
|
||||
struct qe_ep *ep;
|
||||
|
@ -2679,8 +2679,6 @@ static int qe_udc_remove(struct platform_device *ofdev)
|
|||
|
||||
/* wait for release() of gadget.dev to free udc */
|
||||
wait_for_completion(&done);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
/*-------------------------------------------------------------------------*/
|
||||
|
@ -2708,7 +2706,7 @@ static struct platform_driver udc_driver = {
|
|||
.of_match_table = qe_udc_match,
|
||||
},
|
||||
.probe = qe_udc_probe,
|
||||
.remove = qe_udc_remove,
|
||||
.remove_new = qe_udc_remove,
|
||||
#ifdef CONFIG_PM
|
||||
.suspend = qe_udc_suspend,
|
||||
.resume = qe_udc_resume,
|
||||
|
|
Loading…
Reference in a new issue