mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-30 08:02:30 +00:00
drm/hisilicon: Fix return value check in ade_dts_parse()
In case of error, the function devm_clk_get() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Reviewed-by: Chen Feng <puck.chen@hisilicon.com>
This commit is contained in:
parent
dac2c48ca5
commit
43fd0d9230
1 changed files with 6 additions and 6 deletions
|
@ -965,21 +965,21 @@ static int ade_dts_parse(struct platform_device *pdev, struct ade_hw_ctx *ctx)
|
|||
}
|
||||
|
||||
ctx->ade_core_clk = devm_clk_get(dev, "clk_ade_core");
|
||||
if (!ctx->ade_core_clk) {
|
||||
if (IS_ERR(ctx->ade_core_clk)) {
|
||||
DRM_ERROR("failed to parse clk ADE_CORE\n");
|
||||
return -ENODEV;
|
||||
return PTR_ERR(ctx->ade_core_clk);
|
||||
}
|
||||
|
||||
ctx->media_noc_clk = devm_clk_get(dev, "clk_codec_jpeg");
|
||||
if (!ctx->media_noc_clk) {
|
||||
if (IS_ERR(ctx->media_noc_clk)) {
|
||||
DRM_ERROR("failed to parse clk CODEC_JPEG\n");
|
||||
return -ENODEV;
|
||||
return PTR_ERR(ctx->media_noc_clk);
|
||||
}
|
||||
|
||||
ctx->ade_pix_clk = devm_clk_get(dev, "clk_ade_pix");
|
||||
if (!ctx->ade_pix_clk) {
|
||||
if (IS_ERR(ctx->ade_pix_clk)) {
|
||||
DRM_ERROR("failed to parse clk ADE_PIX\n");
|
||||
return -ENODEV;
|
||||
return PTR_ERR(ctx->ade_pix_clk);
|
||||
}
|
||||
|
||||
return 0;
|
||||
|
|
Loading…
Reference in a new issue