mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-29 23:53:32 +00:00
[media] radio: fix error return code
Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
parent
bfe40b79e9
commit
44b0c738c7
1 changed files with 3 additions and 1 deletions
|
@ -138,8 +138,10 @@ static int timbradio_probe(struct platform_device *pdev)
|
|||
i2c_get_adapter(pdata->i2c_adapter), pdata->tuner, NULL);
|
||||
tr->sd_dsp = v4l2_i2c_new_subdev_board(&tr->v4l2_dev,
|
||||
i2c_get_adapter(pdata->i2c_adapter), pdata->dsp, NULL);
|
||||
if (tr->sd_tuner == NULL || tr->sd_dsp == NULL)
|
||||
if (tr->sd_tuner == NULL || tr->sd_dsp == NULL) {
|
||||
err = -ENODEV;
|
||||
goto err_video_req;
|
||||
}
|
||||
|
||||
tr->v4l2_dev.ctrl_handler = tr->sd_dsp->ctrl_handler;
|
||||
|
||||
|
|
Loading…
Reference in a new issue