mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-03 23:58:05 +00:00
misc: rtsx: Fix an error handling path in rtsx_pci_probe()
If an error occurs after a successful idr_alloc() call, the corresponding
resource must be released with idr_remove() as already done in the .remove
function.
Update the error handling path to add the missing idr_remove() call.
Fixes: ada8a8a13b
("mfd: Add realtek pcie card reader driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/e8dc41716cbf52fb37a12e70d8972848e69df6d6.1655271216.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
9864bb4801
commit
44fd191731
1 changed files with 5 additions and 1 deletions
|
@ -1507,7 +1507,7 @@ static int rtsx_pci_probe(struct pci_dev *pcidev,
|
|||
pcr->remap_addr = ioremap(base, len);
|
||||
if (!pcr->remap_addr) {
|
||||
ret = -ENOMEM;
|
||||
goto free_handle;
|
||||
goto free_idr;
|
||||
}
|
||||
|
||||
pcr->rtsx_resv_buf = dma_alloc_coherent(&(pcidev->dev),
|
||||
|
@ -1570,6 +1570,10 @@ static int rtsx_pci_probe(struct pci_dev *pcidev,
|
|||
pcr->rtsx_resv_buf, pcr->rtsx_resv_buf_addr);
|
||||
unmap:
|
||||
iounmap(pcr->remap_addr);
|
||||
free_idr:
|
||||
spin_lock(&rtsx_pci_lock);
|
||||
idr_remove(&rtsx_pci_idr, pcr->id);
|
||||
spin_unlock(&rtsx_pci_lock);
|
||||
free_handle:
|
||||
kfree(handle);
|
||||
free_pcr:
|
||||
|
|
Loading…
Reference in a new issue