mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-28 13:22:57 +00:00
HID: hid-uclogic-params: Invalid parameter check in uclogic_params_frame_init_v1_buttonpad
[ Upstream commitaa320fdbbb
] The function performs a check on the hdev input parameters, however, it is used before the check. Initialize the udev variable after the sanity check to avoid a possible NULL pointer dereference. Fixes:9614219e93
("HID: uclogic: Extract tablet parameter discovery into a module") Addresses-Coverity-ID: 1443763 ("Null pointer dereference") Signed-off-by: José Expósito <jose.exposito89@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
f6fbc6a050
commit
46541f21de
1 changed files with 3 additions and 1 deletions
|
@ -451,7 +451,7 @@ static int uclogic_params_frame_init_v1_buttonpad(
|
|||
{
|
||||
int rc;
|
||||
bool found = false;
|
||||
struct usb_device *usb_dev = hid_to_usb_dev(hdev);
|
||||
struct usb_device *usb_dev;
|
||||
char *str_buf = NULL;
|
||||
const size_t str_len = 16;
|
||||
|
||||
|
@ -461,6 +461,8 @@ static int uclogic_params_frame_init_v1_buttonpad(
|
|||
goto cleanup;
|
||||
}
|
||||
|
||||
usb_dev = hid_to_usb_dev(hdev);
|
||||
|
||||
/*
|
||||
* Enable generic button mode
|
||||
*/
|
||||
|
|
Loading…
Reference in a new issue