mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-04 16:15:11 +00:00
gpio: mpc8xxx: Fix IRQ check in mpc8xxx_probe
commit0b39536cc6
upstream. platform_get_irq() returns negative error number instead 0 on failure. And the doc of platform_get_irq() provides a usage example: int irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; Fix the check of return value to catch errors correctly. Fixes:76c47d1449
("gpio: mpc8xxx: Add ACPI support") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
e7525b3b9e
commit
4928241698
1 changed files with 2 additions and 2 deletions
|
@ -388,8 +388,8 @@ static int mpc8xxx_probe(struct platform_device *pdev)
|
||||||
}
|
}
|
||||||
|
|
||||||
mpc8xxx_gc->irqn = platform_get_irq(pdev, 0);
|
mpc8xxx_gc->irqn = platform_get_irq(pdev, 0);
|
||||||
if (!mpc8xxx_gc->irqn)
|
if (mpc8xxx_gc->irqn < 0)
|
||||||
return 0;
|
return mpc8xxx_gc->irqn;
|
||||||
|
|
||||||
mpc8xxx_gc->irq = irq_domain_create_linear(fwnode,
|
mpc8xxx_gc->irq = irq_domain_create_linear(fwnode,
|
||||||
MPC8XXX_GPIO_PINS,
|
MPC8XXX_GPIO_PINS,
|
||||||
|
|
Loading…
Reference in a new issue