mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-13 14:14:37 +00:00
usb: phy: tahvo: add IRQ check
[ Upstream commit0d45a1373e
] The driver neglects to check the result of platform_get_irq()'s call and blithely passes the negative error codes to request_threaded_irq() (which takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original error code. Stop calling request_threaded_irq() with the invalid IRQ #s. Fixes:9ba96ae507
("usb: omap1: Tahvo USB transceiver driver") Acked-by: Felipe Balbi <balbi@kernel.org> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru> Link: https://lore.kernel.org/r/8280d6a4-8e9a-7cfe-1aa9-db586dc9afdf@omp.ru Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
46638d6941
commit
494629ba62
1 changed files with 3 additions and 1 deletions
|
@ -393,7 +393,9 @@ static int tahvo_usb_probe(struct platform_device *pdev)
|
|||
|
||||
dev_set_drvdata(&pdev->dev, tu);
|
||||
|
||||
tu->irq = platform_get_irq(pdev, 0);
|
||||
tu->irq = ret = platform_get_irq(pdev, 0);
|
||||
if (ret < 0)
|
||||
return ret;
|
||||
ret = request_threaded_irq(tu->irq, NULL, tahvo_usb_vbus_interrupt,
|
||||
IRQF_ONESHOT,
|
||||
"tahvo-vbus", tu);
|
||||
|
|
Loading…
Reference in a new issue