mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 01:10:04 +00:00
media: cec-gpio: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
This commit is contained in:
parent
3228cec23b
commit
4948ea58e7
1 changed files with 2 additions and 3 deletions
|
@ -269,13 +269,12 @@ static int cec_gpio_probe(struct platform_device *pdev)
|
|||
return ret;
|
||||
}
|
||||
|
||||
static int cec_gpio_remove(struct platform_device *pdev)
|
||||
static void cec_gpio_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct cec_gpio *cec = platform_get_drvdata(pdev);
|
||||
|
||||
cec_notifier_cec_adap_unregister(cec->notifier, cec->adap);
|
||||
cec_unregister_adapter(cec->adap);
|
||||
return 0;
|
||||
}
|
||||
|
||||
static const struct of_device_id cec_gpio_match[] = {
|
||||
|
@ -288,7 +287,7 @@ MODULE_DEVICE_TABLE(of, cec_gpio_match);
|
|||
|
||||
static struct platform_driver cec_gpio_pdrv = {
|
||||
.probe = cec_gpio_probe,
|
||||
.remove = cec_gpio_remove,
|
||||
.remove_new = cec_gpio_remove,
|
||||
.driver = {
|
||||
.name = "cec-gpio",
|
||||
.of_match_table = cec_gpio_match,
|
||||
|
|
Loading…
Reference in a new issue