mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 22:02:02 +00:00
net: hns: Switch to use acpi_evaluate_dsm_typed()
The acpi_evaluate_dsm_typed() provides a way to check the type of the object evaluated by _DSM call. Use it instead of open coded variant. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Tony Nguyen <anthony.l.nguyen@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
1b94ad7ccc
commit
498fe81011
1 changed files with 10 additions and 10 deletions
|
@ -554,11 +554,11 @@ static phy_interface_t hns_mac_get_phy_if_acpi(struct hns_mac_cb *mac_cb)
|
||||||
argv4.package.count = 1;
|
argv4.package.count = 1;
|
||||||
argv4.package.elements = &obj_args;
|
argv4.package.elements = &obj_args;
|
||||||
|
|
||||||
obj = acpi_evaluate_dsm(ACPI_HANDLE(mac_cb->dev),
|
obj = acpi_evaluate_dsm_typed(ACPI_HANDLE(mac_cb->dev),
|
||||||
&hns_dsaf_acpi_dsm_guid, 0,
|
&hns_dsaf_acpi_dsm_guid, 0,
|
||||||
HNS_OP_GET_PORT_TYPE_FUNC, &argv4);
|
HNS_OP_GET_PORT_TYPE_FUNC, &argv4,
|
||||||
|
ACPI_TYPE_INTEGER);
|
||||||
if (!obj || obj->type != ACPI_TYPE_INTEGER)
|
if (!obj)
|
||||||
return phy_if;
|
return phy_if;
|
||||||
|
|
||||||
phy_if = obj->integer.value ?
|
phy_if = obj->integer.value ?
|
||||||
|
@ -601,11 +601,11 @@ static int hns_mac_get_sfp_prsnt_acpi(struct hns_mac_cb *mac_cb, int *sfp_prsnt)
|
||||||
argv4.package.count = 1;
|
argv4.package.count = 1;
|
||||||
argv4.package.elements = &obj_args;
|
argv4.package.elements = &obj_args;
|
||||||
|
|
||||||
obj = acpi_evaluate_dsm(ACPI_HANDLE(mac_cb->dev),
|
obj = acpi_evaluate_dsm_typed(ACPI_HANDLE(mac_cb->dev),
|
||||||
&hns_dsaf_acpi_dsm_guid, 0,
|
&hns_dsaf_acpi_dsm_guid, 0,
|
||||||
HNS_OP_GET_SFP_STAT_FUNC, &argv4);
|
HNS_OP_GET_SFP_STAT_FUNC, &argv4,
|
||||||
|
ACPI_TYPE_INTEGER);
|
||||||
if (!obj || obj->type != ACPI_TYPE_INTEGER)
|
if (!obj)
|
||||||
return -ENODEV;
|
return -ENODEV;
|
||||||
|
|
||||||
*sfp_prsnt = obj->integer.value;
|
*sfp_prsnt = obj->integer.value;
|
||||||
|
|
Loading…
Reference in a new issue