mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-25 02:09:42 +00:00
RDMA/bnxt_re: Do not free the ctx_tbl entry if delete GID fails
This fix is added only to avoid system crash in some a specific scenario. When bnxt_re driver is loaded and if user tries to change interface mac address, delete GID fails because QP1 is still associated with existing MAC (default GID). If the above command fails GID tables are not modified in the h/w or driver, but the GID context memory is freed. Now, if the user changes the mac back to the original value, another add_gid comes to the driver where the driver reports that the GID is already present in its table and tries to access the context which was already freed. So, in this case, in order to avoid NULL pointer de-reference, this patch removes the context memory free if delete_gid fails and the same context memory is re-used in new add_gid. Memory cleanup will be taken care during driver unload, while deleting the GID table. Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com> Signed-off-by: Doug Ledford <dledford@redhat.com>
This commit is contained in:
parent
ab69d4c8da
commit
4a62c5e9e2
1 changed files with 9 additions and 7 deletions
|
@ -390,15 +390,17 @@ int bnxt_re_del_gid(struct ib_device *ibdev, u8 port_num,
|
|||
return -EINVAL;
|
||||
ctx->refcnt--;
|
||||
if (!ctx->refcnt) {
|
||||
rc = bnxt_qplib_del_sgid
|
||||
(sgid_tbl,
|
||||
&sgid_tbl->tbl[ctx->idx], true);
|
||||
if (rc)
|
||||
rc = bnxt_qplib_del_sgid(sgid_tbl,
|
||||
&sgid_tbl->tbl[ctx->idx],
|
||||
true);
|
||||
if (rc) {
|
||||
dev_err(rdev_to_dev(rdev),
|
||||
"Failed to remove GID: %#x", rc);
|
||||
ctx_tbl = sgid_tbl->ctx;
|
||||
ctx_tbl[ctx->idx] = NULL;
|
||||
kfree(ctx);
|
||||
} else {
|
||||
ctx_tbl = sgid_tbl->ctx;
|
||||
ctx_tbl[ctx->idx] = NULL;
|
||||
kfree(ctx);
|
||||
}
|
||||
}
|
||||
} else {
|
||||
return -EINVAL;
|
||||
|
|
Loading…
Reference in a new issue