mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-30 22:26:55 +00:00
Code Issues Releases Wiki Activity

greybus: connection: handle static connections

Browse source 
Use host-device device and connection name for log messages rather than
assume that all connections have a bundle (e.g. not true for static
connections).

Note that the "initial" svc connection has never had a bundle.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Johan Hovold 2015-11-25 15:59:15 +01:00 committed by Greg Kroah-Hartman
parent 729b260a67
commit 4c4b502186
1 changed files with 11 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
drivers/staging/greybus/connection.c
View file

@ -208,8 +208,8 @@ gb_connection_create(struct gb_host_device *hd, int hd_cport_id,
retval = gb_connection_bind_protocol(connection); retval = gb_connection_bind_protocol(connection);
if (retval) { if (retval) {
dev_err(&hd->dev, "%d: failed to bind protocol: %d\n", dev_err(&hd->dev, "%s: failed to bind protocol: %d\n",
cport_id, retval); connection->name, retval);
gb_connection_destroy(connection); gb_connection_destroy(connection);
return NULL; return NULL;
} }
@ -320,8 +320,9 @@ gb_connection_svc_connection_create(struct gb_connection *connection)
connection->intf_cport_id, connection->intf_cport_id,
intf->boot_over_unipro); intf->boot_over_unipro);
if (ret) { if (ret) {
dev_err(&connection->bundle->dev, dev_err(&connection->hd->dev,
"failed to create svc connection: %d\n", ret); "%s: failed to create svc connection: %d\n",
connection->name, ret);
return ret; return ret;
} }
@ -513,8 +514,9 @@ void gb_connection_latency_tag_enable(struct gb_connection *connection)
ret = hd->driver->latency_tag_enable(hd, connection->hd_cport_id); ret = hd->driver->latency_tag_enable(hd, connection->hd_cport_id);
if (ret) { if (ret) {
dev_err(&connection->bundle->dev, dev_err(&connection->hd->dev,
"failed to enable latency tag: %d\n", ret); "%s: failed to enable latency tag: %d\n",
connection->name, ret);
} }
} }
EXPORT_SYMBOL_GPL(gb_connection_latency_tag_enable); EXPORT_SYMBOL_GPL(gb_connection_latency_tag_enable);
@ -529,8 +531,9 @@ void gb_connection_latency_tag_disable(struct gb_connection *connection)
ret = hd->driver->latency_tag_disable(hd, connection->hd_cport_id); ret = hd->driver->latency_tag_disable(hd, connection->hd_cport_id);
if (ret) { if (ret) {
dev_err(&connection->bundle->dev, dev_err(&connection->hd->dev,
"failed to disable latency tag: %d\n", ret); "%s: failed to disable latency tag: %d\n",
connection->name, ret);
} }
} }
EXPORT_SYMBOL_GPL(gb_connection_latency_tag_disable); EXPORT_SYMBOL_GPL(gb_connection_latency_tag_disable);