mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-04 01:49:36 +00:00
IB/cm: Avoid a loop when device has 255 ports
[ Upstream commit131be26750
] When RDMA device has 255 ports, loop iterator i overflows. Due to which cm_add_one() port iterator loops infinitely. Use core provided port iterator to avoid the infinite loop. Fixes:a977049dac
("[PATCH] IB: Add the kernel CM implementation") Link: https://lore.kernel.org/r/20210127150010.1876121-9-leon@kernel.org Signed-off-by: Mark Bloch <mbloch@nvidia.com> Signed-off-by: Parav Pandit <parav@nvidia.com> Signed-off-by: Leon Romanovsky <leonro@nvidia.com> Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
180cd50dd9
commit
4cb8bdaebb
1 changed files with 4 additions and 4 deletions
|
@ -4336,7 +4336,7 @@ static void cm_add_one(struct ib_device *ib_device)
|
|||
unsigned long flags;
|
||||
int ret;
|
||||
int count = 0;
|
||||
u8 i;
|
||||
unsigned int i;
|
||||
|
||||
cm_dev = kzalloc(struct_size(cm_dev, port, ib_device->phys_port_cnt),
|
||||
GFP_KERNEL);
|
||||
|
@ -4348,7 +4348,7 @@ static void cm_add_one(struct ib_device *ib_device)
|
|||
cm_dev->going_down = 0;
|
||||
|
||||
set_bit(IB_MGMT_METHOD_SEND, reg_req.method_mask);
|
||||
for (i = 1; i <= ib_device->phys_port_cnt; i++) {
|
||||
rdma_for_each_port (ib_device, i) {
|
||||
if (!rdma_cap_ib_cm(ib_device, i))
|
||||
continue;
|
||||
|
||||
|
@ -4427,7 +4427,7 @@ static void cm_remove_one(struct ib_device *ib_device, void *client_data)
|
|||
.clr_port_cap_mask = IB_PORT_CM_SUP
|
||||
};
|
||||
unsigned long flags;
|
||||
int i;
|
||||
unsigned int i;
|
||||
|
||||
if (!cm_dev)
|
||||
return;
|
||||
|
@ -4440,7 +4440,7 @@ static void cm_remove_one(struct ib_device *ib_device, void *client_data)
|
|||
cm_dev->going_down = 1;
|
||||
spin_unlock_irq(&cm.lock);
|
||||
|
||||
for (i = 1; i <= ib_device->phys_port_cnt; i++) {
|
||||
rdma_for_each_port (ib_device, i) {
|
||||
if (!rdma_cap_ib_cm(ib_device, i))
|
||||
continue;
|
||||
|
||||
|
|
Loading…
Reference in a new issue