mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-06 16:49:22 +00:00
netdevsim: don't overwrite read only ethtool parms
[ Upstream commitee60e626d5
] Ethtool ring feature has _max_pending attributes read-only. Set only read-write attributes in nsim_set_ringparam. This patch is useful, if netdevsim device is set-up using NetworkManager, because NetworkManager sends 0 as MAX values, as it is pointless to retrieve them in extra call, because they should be read-only. Then, the device is left in incosistent state (value > MAX). Fixes:a7fc6db099
("netdevsim: support ethtool ring and coalesce settings") Signed-off-by: Filip Pokryvka <fpokryvk@redhat.com> Link: https://lore.kernel.org/r/20211210175032.411872-1-fpokryvk@redhat.com Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
e5d28205bf
commit
4cd2d21bbe
1 changed files with 4 additions and 1 deletions
|
@ -77,7 +77,10 @@ static int nsim_set_ringparam(struct net_device *dev,
|
|||
{
|
||||
struct netdevsim *ns = netdev_priv(dev);
|
||||
|
||||
memcpy(&ns->ethtool.ring, ring, sizeof(ns->ethtool.ring));
|
||||
ns->ethtool.ring.rx_pending = ring->rx_pending;
|
||||
ns->ethtool.ring.rx_jumbo_pending = ring->rx_jumbo_pending;
|
||||
ns->ethtool.ring.rx_mini_pending = ring->rx_mini_pending;
|
||||
ns->ethtool.ring.tx_pending = ring->tx_pending;
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue