mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-27 12:57:53 +00:00
ceph: fix type promotion bug on 32bit systems
commit07bb00ef00
upstream. In this code "ret" is type long and "src_objlen" is unsigned int. The problem is that on 32bit systems, when we do the comparison signed longs are type promoted to unsigned int. So negative error codes from do_splice_direct() are treated as success instead of failure. Cc: stable@vger.kernel.org Fixes:1b0c3b9f91
("ceph: re-org copy_file_range and fix some error paths") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Xiubo Li <xiubli@redhat.com> Signed-off-by: Ilya Dryomov <idryomov@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
9f43481c0d
commit
4d6c1845cb
1 changed files with 1 additions and 1 deletions
|
@ -2498,7 +2498,7 @@ static ssize_t __ceph_copy_file_range(struct file *src_file, loff_t src_off,
|
|||
ret = do_splice_direct(src_file, &src_off, dst_file,
|
||||
&dst_off, src_objlen, flags);
|
||||
/* Abort on short copies or on error */
|
||||
if (ret < src_objlen) {
|
||||
if (ret < (long)src_objlen) {
|
||||
dout("Failed partial copy (%zd)\n", ret);
|
||||
goto out;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue