mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-08-24 17:59:32 +00:00
Code Issues Releases Wiki Activity

arcnet: Make a char * array const char * const

Browse source 
Might as well be specific about the use of this array.

Add a commment questioning the indexing too.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
This commit is contained in:
Joe Perches 2015-05-05 10:06:04 -07:00 committed by Michael Grzeschik
parent 26c6d28168
commit 4e299b922c
1 changed files with 10 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
drivers/net/arcnet/com20020.c
View file

@ -42,10 +42,10 @@
#include "arcdevice.h" #include "arcdevice.h"
#include "com20020.h" #include "com20020.h"
static char *clockrates[] = { static const char * const clockrates[] = {
"XXXXXXX", "XXXXXXXX", "XXXXXX", "XXXXXXX", "XXXXXXXX", "XXXXXX", "2.5 Mb/s",
"2.5 Mb/s", "1.25Mb/s", "625 Kb/s", "312.5 Kb/s", "1.25Mb/s", "625 Kb/s", "312.5 Kb/s", "156.25 Kb/s",
"156.25 Kb/s", "Reserved", "Reserved", "Reserved" "Reserved", "Reserved", "Reserved"
}; };
static void com20020_command(struct net_device *dev, int command); static void com20020_command(struct net_device *dev, int command);
@ -234,7 +234,12 @@ int com20020_found(struct net_device *dev, int shared)
arc_printk(D_NORMAL, dev, "Using CKP %d - data rate %s\n", arc_printk(D_NORMAL, dev, "Using CKP %d - data rate %s\n",
lp->setup >> 1, lp->setup >> 1,
clockrates[3 - ((lp->setup2 & 0xF0) >> 4) + ((lp->setup & 0x0F) >> 1)]); clockrates[3 -
((lp->setup2 & 0xF0) >> 4) +
((lp->setup & 0x0F) >> 1)]);
/* The clockrates array index looks very fragile.
* It seems like it could have negative indexing.
*/
if (register_netdev(dev)) { if (register_netdev(dev)) {
free_irq(dev->irq, dev); free_irq(dev->irq, dev);