mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-06 08:46:46 +00:00
dpaa2-switch: Fix memory leak in dpaa2_switch_acl_entry_add() and dpaa2_switch_acl_entry_remove()
The cmd_buff needs to be freed when error happened in
dpaa2_switch_acl_entry_add() and dpaa2_switch_acl_entry_remove().
Fixes: 1110318d83
("dpaa2-switch: add tc flower hardware offload on ingress traffic")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Link: https://lore.kernel.org/r/20221205061515.115012-1-yuancan@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
This commit is contained in:
parent
063a932b64
commit
4fad22a128
1 changed files with 4 additions and 0 deletions
|
@ -132,6 +132,7 @@ int dpaa2_switch_acl_entry_add(struct dpaa2_switch_filter_block *filter_block,
|
||||||
DMA_TO_DEVICE);
|
DMA_TO_DEVICE);
|
||||||
if (unlikely(dma_mapping_error(dev, acl_entry_cfg->key_iova))) {
|
if (unlikely(dma_mapping_error(dev, acl_entry_cfg->key_iova))) {
|
||||||
dev_err(dev, "DMA mapping failed\n");
|
dev_err(dev, "DMA mapping failed\n");
|
||||||
|
kfree(cmd_buff);
|
||||||
return -EFAULT;
|
return -EFAULT;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -142,6 +143,7 @@ int dpaa2_switch_acl_entry_add(struct dpaa2_switch_filter_block *filter_block,
|
||||||
DMA_TO_DEVICE);
|
DMA_TO_DEVICE);
|
||||||
if (err) {
|
if (err) {
|
||||||
dev_err(dev, "dpsw_acl_add_entry() failed %d\n", err);
|
dev_err(dev, "dpsw_acl_add_entry() failed %d\n", err);
|
||||||
|
kfree(cmd_buff);
|
||||||
return err;
|
return err;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -172,6 +174,7 @@ dpaa2_switch_acl_entry_remove(struct dpaa2_switch_filter_block *block,
|
||||||
DMA_TO_DEVICE);
|
DMA_TO_DEVICE);
|
||||||
if (unlikely(dma_mapping_error(dev, acl_entry_cfg->key_iova))) {
|
if (unlikely(dma_mapping_error(dev, acl_entry_cfg->key_iova))) {
|
||||||
dev_err(dev, "DMA mapping failed\n");
|
dev_err(dev, "DMA mapping failed\n");
|
||||||
|
kfree(cmd_buff);
|
||||||
return -EFAULT;
|
return -EFAULT;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -182,6 +185,7 @@ dpaa2_switch_acl_entry_remove(struct dpaa2_switch_filter_block *block,
|
||||||
DMA_TO_DEVICE);
|
DMA_TO_DEVICE);
|
||||||
if (err) {
|
if (err) {
|
||||||
dev_err(dev, "dpsw_acl_remove_entry() failed %d\n", err);
|
dev_err(dev, "dpsw_acl_remove_entry() failed %d\n", err);
|
||||||
|
kfree(cmd_buff);
|
||||||
return err;
|
return err;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue