mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-09-13 22:25:03 +00:00
Code Issues Releases Wiki Activity

habanalabs: replace some -ENOTTY with -EINVAL

Browse source 
-ENOTTY is returned in case of error in the ioctl arguments themselves,
such as function that doesn't exists.

In all other cases, where the error is in the arguments of the custom
data structures that we define that are passed in the various ioctls,
we need to return -EINVAL.

Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
This commit is contained in:
Oded Gabbay 2021-12-19 16:06:59 +02:00
parent 0a63ac769b
commit 519f4ed0a0
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/misc/habanalabs/common/command_buffer.c
View file

@ -475,7 +475,7 @@ int hl_cb_ioctl(struct hl_fpriv *hpriv, void *data)
break;
default:
rc = -ENOTTY;
rc = -EINVAL;
break;
}

4
drivers/misc/habanalabs/common/habanalabs_ioctl.c
View file

@ -693,7 +693,7 @@ static int _hl_info_ioctl(struct hl_fpriv *hpriv, void *data,
default:
dev_err(dev, "Invalid request %d\n", args->op);
rc = -ENOTTY;
rc = -EINVAL;
break;
}
@ -748,7 +748,7 @@ static int hl_debug_ioctl(struct hl_fpriv *hpriv, void *data)
default:
dev_err(hdev->dev, "Invalid request %d\n", args->op);
rc = -ENOTTY;
rc = -EINVAL;
break;
}

4
drivers/misc/habanalabs/common/memory.c
View file

@ -2031,7 +2031,7 @@ static int mem_ioctl_no_mmu(struct hl_fpriv *hpriv, union hl_mem_args *args)
default:
dev_err(hdev->dev, "Unknown opcode for memory IOCTL\n");
rc = -ENOTTY;
rc = -EINVAL;
break;
}
@ -2156,7 +2156,7 @@ int hl_mem_ioctl(struct hl_fpriv *hpriv, void *data)
default:
dev_err(hdev->dev, "Unknown opcode for memory IOCTL\n");
rc = -ENOTTY;
rc = -EINVAL;
break;
}