mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-03 17:40:04 +00:00
mfd: Fix more undefined twl4030-power resconfig value checks
Based on Aaro's previous fix, this needs to be fixed for the newly added remap_off and remap_sleep resources as well. The code tries to skip values initialized with -1, but since the values are unsigned the comparison is always true. The patch eliminates the following compiler warnings: drivers/mfd/twl4030-power.c: In function 'twl4030_configure_resource': drivers/mfd/twl4030-power.c:338: warning: comparison is always true due to limited range of data type Signed-off-by: Amit Kucheria <amit.kucheria@verdurent.com> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
This commit is contained in:
parent
3c684e84d1
commit
53cf9a605d
1 changed files with 2 additions and 2 deletions
|
@ -398,12 +398,12 @@ static int __init twl4030_configure_resource(struct twl4030_resconfig *rconfig)
|
|||
return err;
|
||||
}
|
||||
|
||||
if (rconfig->remap_off >= 0) {
|
||||
if (rconfig->remap_off != TWL4030_RESCONFIG_UNDEF) {
|
||||
remap &= ~OFF_STATE_MASK;
|
||||
remap |= rconfig->remap_off << OFF_STATE_SHIFT;
|
||||
}
|
||||
|
||||
if (rconfig->remap_sleep >= 0) {
|
||||
if (rconfig->remap_sleep != TWL4030_RESCONFIG_UNDEF) {
|
||||
remap &= ~SLEEP_STATE_MASK;
|
||||
remap |= rconfig->remap_off << SLEEP_STATE_SHIFT;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue