mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-07 00:59:06 +00:00
cifs: remove bogus remapping of error in cifs_filldir()
As the FIXME points out correctly, now filldir() itself returns -EOVERFLOW if it not possible to represent the inode number supplied by the filesystem in the field provided by userspace. Signed-off-by: Suresh Jayaraman <sjayaraman@suse.de> Reviewed-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Steve French <sfrench@us.ibm.com>
This commit is contained in:
parent
7d161b7f41
commit
545c988b20
1 changed files with 0 additions and 12 deletions
|
@ -759,18 +759,6 @@ static int cifs_filldir(char *pfindEntry, struct file *file, filldir_t filldir,
|
||||||
rc = filldir(direntry, qstring.name, qstring.len, file->f_pos,
|
rc = filldir(direntry, qstring.name, qstring.len, file->f_pos,
|
||||||
ino, fattr.cf_dtype);
|
ino, fattr.cf_dtype);
|
||||||
|
|
||||||
/*
|
|
||||||
* we can not return filldir errors to the caller since they are
|
|
||||||
* "normal" when the stat blocksize is too small - we return remapped
|
|
||||||
* error instead
|
|
||||||
*
|
|
||||||
* FIXME: This looks bogus. filldir returns -EOVERFLOW in the above
|
|
||||||
* case already. Why should we be clobbering other errors from it?
|
|
||||||
*/
|
|
||||||
if (rc) {
|
|
||||||
cFYI(1, "filldir rc = %d", rc);
|
|
||||||
rc = -EOVERFLOW;
|
|
||||||
}
|
|
||||||
dput(tmp_dentry);
|
dput(tmp_dentry);
|
||||||
return rc;
|
return rc;
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue