From 552699bcabdd1effe8b5d64d557556928bf6b83a Mon Sep 17 00:00:00 2001 From: Ajay Singh Date: Fri, 16 Feb 2018 20:41:48 +0530 Subject: [PATCH] staging: wilc1000: fix line over 80 chars in wilc_wlan_txq_filter_dup_tcp_ack() Fix "line over 80 characters" issue reported by checkpatch.pl. Use temporary variable to avoid checkpatch.pl issue. Signed-off-by: Ajay Singh Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wilc1000/wilc_wlan.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c index 391ecd5de4b9..98cd949f8115 100644 --- a/drivers/staging/wilc1000/wilc_wlan.c +++ b/drivers/staging/wilc1000/wilc_wlan.c @@ -262,10 +262,20 @@ static int wilc_wlan_txq_filter_dup_tcp_ack(struct net_device *dev) spin_lock_irqsave(&wilc->txq_spinlock, wilc->txq_spinlock_flags); for (i = pending_base; i < (pending_base + pending_acks); i++) { - if (i >= MAX_PENDING_ACKS || - pending_acks_info[i].session_index >= 2 * MAX_TCP_SESSION) + u32 session_index; + u32 bigger_ack_num; + + if (i >= MAX_PENDING_ACKS) break; - if (pending_acks_info[i].ack_num < ack_session_info[pending_acks_info[i].session_index].bigger_ack_num) { + + session_index = pending_acks_info[i].session_index; + + if (session_index >= 2 * MAX_TCP_SESSION) + break; + + bigger_ack_num = ack_session_info[session_index].bigger_ack_num; + + if (pending_acks_info[i].ack_num < bigger_ack_num) { struct txq_entry_t *tqe; tqe = pending_acks_info[i].txqe;