mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-23 09:19:51 +00:00
net: stmmac: dwmac-qcom-ethqos: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Reviewed-by: Simon Horman <simon.horman@corigine.com> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> Reviewed-by: Michal Kubiak <michal.kubiak@intel.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
parent
360cd89064
commit
5580b559a8
1 changed files with 2 additions and 4 deletions
|
@ -665,14 +665,12 @@ static int qcom_ethqos_probe(struct platform_device *pdev)
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
static int qcom_ethqos_remove(struct platform_device *pdev)
|
static void qcom_ethqos_remove(struct platform_device *pdev)
|
||||||
{
|
{
|
||||||
struct qcom_ethqos *ethqos = get_stmmac_bsp_priv(&pdev->dev);
|
struct qcom_ethqos *ethqos = get_stmmac_bsp_priv(&pdev->dev);
|
||||||
|
|
||||||
stmmac_pltfr_remove(pdev);
|
stmmac_pltfr_remove(pdev);
|
||||||
ethqos_clks_config(ethqos, false);
|
ethqos_clks_config(ethqos, false);
|
||||||
|
|
||||||
return 0;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
static const struct of_device_id qcom_ethqos_match[] = {
|
static const struct of_device_id qcom_ethqos_match[] = {
|
||||||
|
@ -685,7 +683,7 @@ MODULE_DEVICE_TABLE(of, qcom_ethqos_match);
|
||||||
|
|
||||||
static struct platform_driver qcom_ethqos_driver = {
|
static struct platform_driver qcom_ethqos_driver = {
|
||||||
.probe = qcom_ethqos_probe,
|
.probe = qcom_ethqos_probe,
|
||||||
.remove = qcom_ethqos_remove,
|
.remove_new = qcom_ethqos_remove,
|
||||||
.driver = {
|
.driver = {
|
||||||
.name = "qcom-ethqos",
|
.name = "qcom-ethqos",
|
||||||
.pm = &stmmac_pltfr_pm_ops,
|
.pm = &stmmac_pltfr_pm_ops,
|
||||||
|
|
Loading…
Reference in a new issue