mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 02:39:48 +00:00
lightnvm: Fix uninitialized return value in nvm_get_chunk_meta()
With gcc 4.1: drivers/lightnvm/core.c: In function ‘nvm_get_bb_meta’: drivers/lightnvm/core.c:977: warning: ‘ret’ may be used uninitialized in this function and drivers/nvme/host/lightnvm.c: In function ‘nvme_nvm_get_chk_meta’: drivers/nvme/host/lightnvm.c:580: warning: ‘ret’ may be used uninitialized in this function Indeed, if (for the former) the number of channels or LUNs is zero, or (for both) the passed number of chunks is zero, ret will be returned uninitialized. Fix this by preinitializing ret to zero. Fixes:aff3fb18f9
("lightnvm: move bad block and chunk state logic to core") Fixes:a294c19945
("lightnvm: implement get log report chunk helpers") Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Matias Bjørling <mb@lightnvm.io> Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
parent
f40a62d267
commit
55e58c5e78
2 changed files with 3 additions and 2 deletions
|
@ -974,7 +974,7 @@ static int nvm_get_bb_meta(struct nvm_dev *dev, sector_t slba,
|
|||
struct ppa_addr ppa;
|
||||
u8 *blks;
|
||||
int ch, lun, nr_blks;
|
||||
int ret;
|
||||
int ret = 0;
|
||||
|
||||
ppa.ppa = slba;
|
||||
ppa = dev_to_generic_addr(dev, ppa);
|
||||
|
|
|
@ -577,7 +577,8 @@ static int nvme_nvm_get_chk_meta(struct nvm_dev *ndev,
|
|||
struct ppa_addr ppa;
|
||||
size_t left = nchks * sizeof(struct nvme_nvm_chk_meta);
|
||||
size_t log_pos, offset, len;
|
||||
int ret, i, max_len;
|
||||
int i, max_len;
|
||||
int ret = 0;
|
||||
|
||||
/*
|
||||
* limit requests to maximum 256K to avoid issuing arbitrary large
|
||||
|
|
Loading…
Reference in a new issue