mirrors/linux-stable
1
0
Fork 0
mirror of https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git synced 2024-10-29 23:53:32 +00:00
Code Issues Releases Wiki Activity

xfs: Fix 'set but not used' warning in xfs_bmap_compute_alignments()

Browse source 
With both CONFIG_XFS_DEBUG and CONFIG_XFS_WARN disabled, the only reference to
local variable "error" in xfs_bmap_compute_alignments() gets eliminated during
pre-processing stage of the compilation process. This causes the compiler to
generate a "set but not used" warning.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Brian Foster <bfoster@redhat.com>
This commit is contained in:
Chandan Babu R 2021-01-27 08:35:14 -08:00 committed by Darrick J. Wong
parent 4533fc6315
commit 560ab6c0d1
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
fs/xfs/libxfs/xfs_bmap.c
View file

@ -3471,7 +3471,6 @@ xfs_bmap_compute_alignments(
struct xfs_mount *mp = args->mp; struct xfs_mount *mp = args->mp;
xfs_extlen_t align = 0; /* minimum allocation alignment */ xfs_extlen_t align = 0; /* minimum allocation alignment */
int stripe_align = 0; int stripe_align = 0;
int error;
/* stripe alignment for allocation is determined by mount parameters */ /* stripe alignment for allocation is determined by mount parameters */
if (mp->m_swidth && (mp->m_flags & XFS_MOUNT_SWALLOC)) if (mp->m_swidth && (mp->m_flags & XFS_MOUNT_SWALLOC))
@ -3484,10 +3483,10 @@ xfs_bmap_compute_alignments(
else if (ap->datatype & XFS_ALLOC_USERDATA) else if (ap->datatype & XFS_ALLOC_USERDATA)
align = xfs_get_extsz_hint(ap->ip); align = xfs_get_extsz_hint(ap->ip);
if (align) { if (align) {
error = xfs_bmap_extsize_align(mp, &ap->got, &ap->prev, if (xfs_bmap_extsize_align(mp, &ap->got, &ap->prev, align, 0,
align, 0, ap->eof, 0, ap->conv, ap->eof, 0, ap->conv, &ap->offset,
&ap->offset, &ap->length); &ap->length))
ASSERT(!error); ASSERT(0);
ASSERT(ap->length); ASSERT(ap->length);
} }