mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 14:19:16 +00:00
usb: dwc3: qcom: Fix memory leak in dwc3_qcom_interconnect_init
[ Upstream commit97a48da161
] of_icc_get() alloc resources for path handle, we should release it when not need anymore. Like the release in dwc3_qcom_interconnect_exit() function. Add icc_put() in error handling to fix this. Fixes:bea46b9815
("usb: dwc3: qcom: Add interconnect support in dwc3 driver") Cc: stable <stable@kernel.org> Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> Signed-off-by: Miaoqian Lin <linmq006@gmail.com> Link: https://lore.kernel.org/r/20221206081731.818107-1-linmq006@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
parent
90ffbb727c
commit
56f6de394f
1 changed files with 10 additions and 3 deletions
|
@ -258,7 +258,8 @@ static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
|
|||
if (IS_ERR(qcom->icc_path_apps)) {
|
||||
dev_err(dev, "failed to get apps-usb path: %ld\n",
|
||||
PTR_ERR(qcom->icc_path_apps));
|
||||
return PTR_ERR(qcom->icc_path_apps);
|
||||
ret = PTR_ERR(qcom->icc_path_apps);
|
||||
goto put_path_ddr;
|
||||
}
|
||||
|
||||
if (usb_get_maximum_speed(&qcom->dwc3->dev) >= USB_SPEED_SUPER ||
|
||||
|
@ -271,17 +272,23 @@ static int dwc3_qcom_interconnect_init(struct dwc3_qcom *qcom)
|
|||
|
||||
if (ret) {
|
||||
dev_err(dev, "failed to set bandwidth for usb-ddr path: %d\n", ret);
|
||||
return ret;
|
||||
goto put_path_apps;
|
||||
}
|
||||
|
||||
ret = icc_set_bw(qcom->icc_path_apps,
|
||||
APPS_USB_AVG_BW, APPS_USB_PEAK_BW);
|
||||
if (ret) {
|
||||
dev_err(dev, "failed to set bandwidth for apps-usb path: %d\n", ret);
|
||||
return ret;
|
||||
goto put_path_apps;
|
||||
}
|
||||
|
||||
return 0;
|
||||
|
||||
put_path_apps:
|
||||
icc_put(qcom->icc_path_apps);
|
||||
put_path_ddr:
|
||||
icc_put(qcom->icc_path_ddr);
|
||||
return ret;
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
Loading…
Reference in a new issue