mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-30 06:10:56 +00:00
net: dsa: mt7530: Change the LINK bit to reflect the link status
[ Upstream commit22259471b5
] Andrew reported: After a number of network port link up/down changes, sometimes the switch port gets stuck in a state where it thinks it is still transmitting packets but the cpu port is not actually transmitting anymore. In this state you will see a message on the console "mtk_soc_eth 1e100000.ethernet eth0: transmit timed out" and the Tx counter in ifconfig will be incrementing on virtual port, but not incrementing on cpu port. The issue is that MAC TX/RX status has no impact on the link status or queue manager of the switch. So the queue manager just queues up packets of a disabled port and sends out pause frames when the queue is full. Change the LINK bit to reflect the link status. Fixes:b8f126a8d5
("net-next: dsa: add dsa support for Mediatek MT7530 switch") Reported-by: Andrew Smith <andrew.smith@digi.com> Signed-off-by: René van Dorst <opensource@vdorst.com> Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
f5ebb2dd86
commit
579efdbbb2
1 changed files with 1 additions and 1 deletions
|
@ -549,7 +549,7 @@ mt7530_mib_reset(struct dsa_switch *ds)
|
|||
static void
|
||||
mt7530_port_set_status(struct mt7530_priv *priv, int port, int enable)
|
||||
{
|
||||
u32 mask = PMCR_TX_EN | PMCR_RX_EN;
|
||||
u32 mask = PMCR_TX_EN | PMCR_RX_EN | PMCR_FORCE_LNK;
|
||||
|
||||
if (enable)
|
||||
mt7530_set(priv, MT7530_PMCR_P(port), mask);
|
||||
|
|
Loading…
Reference in a new issue