mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-14 06:35:12 +00:00
IB/qib: Minor fixes to qib per SFF 8636
Minor errors found via code inspection during future development. SFF 8636 defines bit position 2 to hold the status indication of QSFP memory paging. The mask used to test for the value was incorrect and is fixed in this patch. Additionally, the dump function had a mismatch between the field being printed out and the field used to source the data which was fixed. Reviewed-by: Mitko Haralanov <mitko.haralanov@intel.com> Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com> Reported-by: Easwar Hariharan <easwar.hariharan@intel.com> Signed-off-by: Easwar Hariharan <easwar.hariharan@intel.com> Signed-off-by: Mike Marciniszyn <mike.marciniszyn@intel.com> Signed-off-by: Doug Ledford <dledford@redhat.com>
This commit is contained in:
parent
1d784b890c
commit
57ab251213
1 changed files with 2 additions and 2 deletions
|
@ -292,7 +292,7 @@ int qib_refresh_qsfp_cache(struct qib_pportdata *ppd, struct qib_qsfp_cache *cp)
|
||||||
qib_dev_porterr(ppd->dd, ppd->port,
|
qib_dev_porterr(ppd->dd, ppd->port,
|
||||||
"QSFP byte0 is 0x%02X, S/B 0x0C/D\n", peek[0]);
|
"QSFP byte0 is 0x%02X, S/B 0x0C/D\n", peek[0]);
|
||||||
|
|
||||||
if ((peek[2] & 2) == 0) {
|
if ((peek[2] & 4) == 0) {
|
||||||
/*
|
/*
|
||||||
* If cable is paged, rather than "flat memory", we need to
|
* If cable is paged, rather than "flat memory", we need to
|
||||||
* set the page to zero, Even if it already appears to be zero.
|
* set the page to zero, Even if it already appears to be zero.
|
||||||
|
@ -538,7 +538,7 @@ int qib_qsfp_dump(struct qib_pportdata *ppd, char *buf, int len)
|
||||||
sofar += scnprintf(buf + sofar, len - sofar, "Date:%.*s\n",
|
sofar += scnprintf(buf + sofar, len - sofar, "Date:%.*s\n",
|
||||||
QSFP_DATE_LEN, cd.date);
|
QSFP_DATE_LEN, cd.date);
|
||||||
sofar += scnprintf(buf + sofar, len - sofar, "Lot:%.*s\n",
|
sofar += scnprintf(buf + sofar, len - sofar, "Lot:%.*s\n",
|
||||||
QSFP_LOT_LEN, cd.date);
|
QSFP_LOT_LEN, cd.lot);
|
||||||
|
|
||||||
while (bidx < QSFP_DEFAULT_HDR_CNT) {
|
while (bidx < QSFP_DEFAULT_HDR_CNT) {
|
||||||
int iidx;
|
int iidx;
|
||||||
|
|
Loading…
Reference in a new issue