mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 21:57:43 +00:00
btrfs: send: remove BUG_ON from name_cache_delete
If cleaning the name cache fails, we could try to proceed at the cost of some memory leak. This is not expected to happen often. Signed-off-by: David Sterba <dsterba@suse.cz> Signed-off-by: Josef Bacik <jbacik@fb.com>
This commit is contained in:
parent
4d1a63b21b
commit
57fb8910c2
1 changed files with 9 additions and 2 deletions
|
@ -1890,13 +1890,20 @@ static void name_cache_delete(struct send_ctx *sctx,
|
||||||
|
|
||||||
nce_head = radix_tree_lookup(&sctx->name_cache,
|
nce_head = radix_tree_lookup(&sctx->name_cache,
|
||||||
(unsigned long)nce->ino);
|
(unsigned long)nce->ino);
|
||||||
BUG_ON(!nce_head);
|
if (!nce_head) {
|
||||||
|
btrfs_err(sctx->send_root->fs_info,
|
||||||
|
"name_cache_delete lookup failed ino %llu cache size %d, leaking memory",
|
||||||
|
nce->ino, sctx->name_cache_size);
|
||||||
|
}
|
||||||
|
|
||||||
list_del(&nce->radix_list);
|
list_del(&nce->radix_list);
|
||||||
list_del(&nce->list);
|
list_del(&nce->list);
|
||||||
sctx->name_cache_size--;
|
sctx->name_cache_size--;
|
||||||
|
|
||||||
if (list_empty(nce_head)) {
|
/*
|
||||||
|
* We may not get to the final release of nce_head if the lookup fails
|
||||||
|
*/
|
||||||
|
if (nce_head && list_empty(nce_head)) {
|
||||||
radix_tree_delete(&sctx->name_cache, (unsigned long)nce->ino);
|
radix_tree_delete(&sctx->name_cache, (unsigned long)nce->ino);
|
||||||
kfree(nce_head);
|
kfree(nce_head);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue