mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-12 21:57:43 +00:00
wm97xx_battery: Fix error return code
Initialize return variable before exiting on an error path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
This commit is contained in:
parent
fc2bc0c29a
commit
588d4f0b05
1 changed files with 3 additions and 1 deletions
|
@ -212,8 +212,10 @@ static int __devinit wm97xx_bat_probe(struct platform_device *dev)
|
||||||
props++; /* POWER_SUPPLY_PROP_VOLTAGE_MIN */
|
props++; /* POWER_SUPPLY_PROP_VOLTAGE_MIN */
|
||||||
|
|
||||||
prop = kzalloc(props * sizeof(*prop), GFP_KERNEL);
|
prop = kzalloc(props * sizeof(*prop), GFP_KERNEL);
|
||||||
if (!prop)
|
if (!prop) {
|
||||||
|
ret = -ENOMEM;
|
||||||
goto err3;
|
goto err3;
|
||||||
|
}
|
||||||
|
|
||||||
prop[i++] = POWER_SUPPLY_PROP_PRESENT;
|
prop[i++] = POWER_SUPPLY_PROP_PRESENT;
|
||||||
if (pdata->charge_gpio >= 0)
|
if (pdata->charge_gpio >= 0)
|
||||||
|
|
Loading…
Reference in a new issue