mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-01 14:44:12 +00:00
staging: rtl8192e: GetTs Fix invalid TID 7 warning.
commit 95d93e271d
upstream.
TID 7 is a valid value for QoS IEEE 802.11e.
The switch statement that follows states 7 is valid.
Remove function IsACValid and use the default case to filter
invalid TIDs.
Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
93a46fe4eb
commit
58e36d6f7f
1 changed files with 4 additions and 11 deletions
|
@ -306,11 +306,6 @@ static void MakeTSEntry(struct ts_common_info *pTsCommonInfo, u8 *Addr,
|
||||||
pTsCommonInfo->TClasNum = TCLAS_Num;
|
pTsCommonInfo->TClasNum = TCLAS_Num;
|
||||||
}
|
}
|
||||||
|
|
||||||
static bool IsACValid(unsigned int tid)
|
|
||||||
{
|
|
||||||
return tid < 7;
|
|
||||||
}
|
|
||||||
|
|
||||||
bool GetTs(struct rtllib_device *ieee, struct ts_common_info **ppTS,
|
bool GetTs(struct rtllib_device *ieee, struct ts_common_info **ppTS,
|
||||||
u8 *Addr, u8 TID, enum tr_select TxRxSelect, bool bAddNewTs)
|
u8 *Addr, u8 TID, enum tr_select TxRxSelect, bool bAddNewTs)
|
||||||
{
|
{
|
||||||
|
@ -328,12 +323,6 @@ bool GetTs(struct rtllib_device *ieee, struct ts_common_info **ppTS,
|
||||||
if (ieee->current_network.qos_data.supported == 0) {
|
if (ieee->current_network.qos_data.supported == 0) {
|
||||||
UP = 0;
|
UP = 0;
|
||||||
} else {
|
} else {
|
||||||
if (!IsACValid(TID)) {
|
|
||||||
netdev_warn(ieee->dev, "%s(): TID(%d) is not valid\n",
|
|
||||||
__func__, TID);
|
|
||||||
return false;
|
|
||||||
}
|
|
||||||
|
|
||||||
switch (TID) {
|
switch (TID) {
|
||||||
case 0:
|
case 0:
|
||||||
case 3:
|
case 3:
|
||||||
|
@ -351,6 +340,10 @@ bool GetTs(struct rtllib_device *ieee, struct ts_common_info **ppTS,
|
||||||
case 7:
|
case 7:
|
||||||
UP = 7;
|
UP = 7;
|
||||||
break;
|
break;
|
||||||
|
default:
|
||||||
|
netdev_warn(ieee->dev, "%s(): TID(%d) is not valid\n",
|
||||||
|
__func__, TID);
|
||||||
|
return false;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue