mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-02 15:18:19 +00:00
media: exynos-gsc: fix pm_runtime_get_sync() usage count
The pm_runtime_get_sync() internally increments the
dev->power.usage_count without decrementing it, even on errors.
Replace it by the new pm_runtime_resume_and_get(), introduced by:
commit dd8088d5a8
("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter")
in order to properly decrement the usage counter, avoiding
a potential PM usage counter leak.
As a bonus, as pm_runtime_get_sync() always return 0 on
success, the logic can be simplified.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
parent
59f96244af
commit
59087b66ea
1 changed files with 1 additions and 3 deletions
|
@ -56,10 +56,8 @@ static void __gsc_m2m_job_abort(struct gsc_ctx *ctx)
|
|||
static int gsc_m2m_start_streaming(struct vb2_queue *q, unsigned int count)
|
||||
{
|
||||
struct gsc_ctx *ctx = q->drv_priv;
|
||||
int ret;
|
||||
|
||||
ret = pm_runtime_get_sync(&ctx->gsc_dev->pdev->dev);
|
||||
return ret > 0 ? 0 : ret;
|
||||
return pm_runtime_resume_and_get(&ctx->gsc_dev->pdev->dev);
|
||||
}
|
||||
|
||||
static void __gsc_m2m_cleanup_queue(struct gsc_ctx *ctx)
|
||||
|
|
Loading…
Reference in a new issue