mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 05:44:11 +00:00
netfilter: nf_tables: free chain context when BINDING flag is missing
syzbot found a memory leak in nf_tables_addchain() because the chain
object is not free'd correctly on error.
Fixes: d0e2c7de92
("netfilter: nf_tables: add NFT_CHAIN_BINDING")
Reported-by: syzbot+c99868fde67014f7e9f5@syzkaller.appspotmail.com
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
This commit is contained in:
parent
2404b73c3f
commit
59136aa3b2
1 changed files with 4 additions and 2 deletions
|
@ -2018,8 +2018,10 @@ static int nf_tables_addchain(struct nft_ctx *ctx, u8 family, u8 genmask,
|
||||||
if (nla[NFTA_CHAIN_NAME]) {
|
if (nla[NFTA_CHAIN_NAME]) {
|
||||||
chain->name = nla_strdup(nla[NFTA_CHAIN_NAME], GFP_KERNEL);
|
chain->name = nla_strdup(nla[NFTA_CHAIN_NAME], GFP_KERNEL);
|
||||||
} else {
|
} else {
|
||||||
if (!(flags & NFT_CHAIN_BINDING))
|
if (!(flags & NFT_CHAIN_BINDING)) {
|
||||||
return -EINVAL;
|
err = -EINVAL;
|
||||||
|
goto err1;
|
||||||
|
}
|
||||||
|
|
||||||
snprintf(name, sizeof(name), "__chain%llu", ++chain_id);
|
snprintf(name, sizeof(name), "__chain%llu", ++chain_id);
|
||||||
chain->name = kstrdup(name, GFP_KERNEL);
|
chain->name = kstrdup(name, GFP_KERNEL);
|
||||||
|
|
Loading…
Reference in a new issue